Repository navigation
doc(linstor): fix wrong comments on _call_local_method - #180
Merged
Wescoeur merged 1 commit intoOct 7, 2026
Merged
Conversation
Ythogtha
force-pushed
the
agf-linstor_call_retry_on_ENODATA_ENOENT
branch
from
October 5, 2026 15:44
2be6216 to
07bd954
Compare
Ythogtha
force-pushed
the
agf-linstor_call_retry_on_ENODATA_ENOENT
branch
from
October 5, 2026 15:47
07bd954 to
cc0ef59
Compare
Ythogtha
marked this pull request as draft
October 5, 2026 16:23
Ythogtha
force-pushed
the
agf-linstor_call_retry_on_ENODATA_ENOENT
branch
from
October 6, 2026 07:32
cc0ef59 to
f9d6b6f
Compare
Ythogtha
changed the title
Ythogtha
marked this pull request as ready for review
October 6, 2026 09:10
Ythogtha
force-pushed
the
agf-linstor_call_retry_on_ENODATA_ENOENT
branch
from
October 6, 2026 09:13
f9d6b6f to
0bd8521
Compare
Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
Ythogtha
changed the title
Wescoeur
changed the title
Wescoeur
approved these changes
Oct 6, 2026
Kuruyia
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util.retry(local_call)states that it should stop retrying on EROFS Exception.The actual code will do the same for ENODATA or ENOENT.
Though ENODATA could be transient on DRBD, therefore being a good reason for retrying.
ENODATA is retried directly on blktap2.
The comment was out-of-date, this PR fixes it, avoiding future confusion.